Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vasilis/ortholearner refactor #132

Merged
merged 65 commits into from
Nov 5, 2019
Merged

Conversation

vasilismsr
Copy link
Contributor

No description provided.

vasilismsr and others added 26 commits November 1, 2019 21:37
…tructured _RLearner to be subclass of _OrthoLearner. Small modifiications to first stage and final wrappers in DML and in preprocessing done at the beginning of statsmodels inference.
…ualization inside the _RLearner when both X nad W are None
…learner do not contain all the indices. We now call fit model final only on that subset of indices for which we have calculated their nuisance values.
…learner do not contain all the indices. We now call fit model final only on that subset of indices for which we have calculated their nuisance values.
… classes and models of child classesto omit keyword arguments in their signature if those will always be equal to None.
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Make sure to squash when merging so we don't have lots of meaningless commits.

@vasilismsr vasilismsr merged commit d416b6b into master Nov 5, 2019
@kbattocchi kbattocchi deleted the vasilis/ortholearner_refactor branch November 5, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants